Skip to content

Conversation

@ddworak
Copy link
Member

@ddworak ddworak commented Dec 30, 2025

This pull request makes several important updates to the project's build, CI/CD workflows, and Scala.js/jQuery bindings. The main goals are to modernize build tooling, improve CI reliability, and enhance type safety in the Scala.js jQuery facade.

Build and CI/CD Modernization:

  • Upgraded all available dependencies.
  • Replaced separate sbt-pgp and sbt-sonatype plugins with sbt-ci-release and added sbt-github-actions for streamlined release and workflow generation.

GitHub Actions Workflow Improvements:

  • Regenerated .github/workflows/ci.yml using sbt-github-actions, improving matrix builds (multiple Java versions), build/test/publish separation, and artifact publishing via ci-release.
  • Added .github/workflows/clean.yml for automated cleanup of GitHub Actions artifacts, reducing storage usage.

Scala.js jQuery Facade Improvements:

  • Changed the types of scrollLeft and scrollTop methods in JQuery.scala from Int to Double to prevent runtime errors.
  • Fixed the signature of the error callback in JQueryAjaxSettings.apply to accept three arguments (JQueryXHR, String, String), matching the jQuery API API discuss #31

@ddworak ddworak changed the title Typing issues scala-js-jquery 2026 Dec 30, 2025
@ddworak ddworak changed the title scala-js-jquery 2026 Cleaning up scala-js-jquery for 2026 Dec 30, 2025
@ddworak ddworak merged commit 741fdbb into master Dec 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants