Add controller generator and test #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @scott-knight . Pushed pretty much the same thing, went on your issue to comment and saw you've already created PR (ahhh Github notifications). After seeing that I've edited my commit and added you as a co-author (2161fd2). Feel free to expand on this with a new PR, since you had more test coverage ❤️ |
|
Thank you Dino, I appreciate it.
…Sent from my iPhone
On Sep 30, 2021, at 5:16 PM, Dino Maric ***@***.***> wrote:
Thank you @scott-knight . Pushed pretty much the same thing, went on your issue to comment and saw you've already created PR (ahhh Github notifications).
After seeing that I've edited my commit and added you as a co-author (2161fd2).
Sorry my bad didn't see that you've already created a PR
Feel free to expand on this with a new PR, since you had more test coverage ❤️
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using rails g controller a user will experience an error generating the view:
This PR adds the controller generator and view template which will all a user to use rails g controller:
I also ran into an issue run the test suite. Therefore, I updated each test file to point to the required test_helper file.
Additionally, I updated the version (which is arbitrary), but did so to differentiate this from the original source.