Skip to content

Logical properties #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Logical properties #27

wants to merge 5 commits into from

Conversation

Yohn
Copy link
Owner

@Yohn Yohn commented Jan 3, 2025

@Yohn
Copy link
Owner Author

Yohn commented Jan 8, 2025

I noticed some scss files are using both

padding-right: **;
padding-left: **;
padding-inline-start: **;
padding-inline-end: **;

When it should be only using the latter, *-inline-start & *-inline-end. I found this within the following file but there could be more.

padding-right: calc(
var(#{$css-var-prefix}form-element-spacing-horizontal) + 1.5rem
) !important;
padding-left: var(#{$css-var-prefix}form-element-spacing-horizontal);
padding-inline-start: var(#{$css-var-prefix}form-element-spacing-horizontal) !important;
padding-inline-end: calc(
var(#{$css-var-prefix}form-element-spacing-horizontal) + 1.5rem
) !important;
} @else {
padding-right: calc(var(#{$css-var-prefix}form-element-spacing-horizontal) + 1.5rem);
padding-left: var(#{$css-var-prefix}form-element-spacing-horizontal);
padding-inline-start: var(#{$css-var-prefix}form-element-spacing-horizontal);
padding-inline-end: calc(var(#{$css-var-prefix}form-element-spacing-horizontal) + 1.5rem);
}

@Yohn
Copy link
Owner Author

Yohn commented Jan 20, 2025

closed for #47

@Yohn Yohn closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants