Not compatible with YUI Compressor #147
Description
The conditional comment for IE6 detection causes an error with yui-compressor the way it's written. Although not technically a 'bug' with this code, there is a trivial work-around that can be added in that would certainly classify as an 'improvement'.
YUI Error encountered:
[yui-compressor] 500:70:missing ; before statement
[yui-compressor] 1:0:Compilation produced 1 syntax errors.
Here's the quick patch showing the way I quickly worked around it (there may be a better approach, but without really reviewing the code, this seemed appropriate).
--- fhe/js/third-party/jquery.columnizer.js (revision redacted)
+++ fhe/js/third-party/jquery.columnizer.js (working copy)
@@ -497,7 +497,12 @@
}
}
if(options.overflow && !scrollHorizontally){
- var IE6 = false /*@cc_on || @_jscript_version < 5.7 @*/;
+ var IE6 = false;
+/*@cc_on
+ @if (@_jscript_version < 5.7)
+ IE6 = true;
+ @end
+@*/
var IE7 = (document.all) && (navigator.appVersion.indexOf("MSIE 7.") != -1);
if(IE6 || IE7){
var html = "";