Wrong 'dontsplit' condition

[kirara]

In https://github.com/adamwulf/Columnizer-jQuery-Plugin/blob/master/src/jquery.columnizer.js#L253:

}else if(!$cloneMe.hasClass(prefixTheClassName("dontsplit")) && $parentColumn.height() < targetHeight + 20){
//
// pretty close fit, and we're not allowed to split it, so just
// add it to the column, remove from pullOutHere, and be done
$cloneMe.remove();

the NOT operator seems to be wrong.
Commentary says "we're not allowed to split it". That translates to "node has 'dontsplit' class". This is other way around.

[adamwulf]

yeah something definitely seems off there. i haven't received any
complaints about dontsplit not working, so i'm assuming my comment is
wrong? either way i'll take a closer look and get this fixed, thanks for
the heads up

Adam

On Fri, Dec 14, 2012 at 6:42 PM, Martin Vendl notifications@github.comwrote:

In
https://github.com/adamwulf/Columnizer-jQuery-Plugin/blob/master/src/jquery.columnizer.js#L258:

}else if(!$cloneMe.hasClass(prefixTheClassName("dontsplit")) && $parentColumn.height() < targetHeight + 20){//// pretty close fit, and we're not allowed to split it, so just// add it to the column, remove from pullOutHere, and be done$cloneMe.remove();

the NOT operator seems to be wrong.
Commentary says "we're not allowed to split it". That translates to "node
has 'dontsplit' class". This is other way around.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/76.

[kirara]

This is a "close fit" case. 'Dontsplit' works in a sense, but when encountered it always put the whole node to the next column. Worse thing is, because of this condition, it never procedes to split text in a "close fit" case, even if it could (no 'dontsplit' class).
If I don't have any dontsplit element (or image) it should never overflow stated height, not by a single pixel. But it does.

[adamwulf]

ah i see. yeah the dontsplit uses a bit of a buffer in the height so that columns still stay mostly balanced if a dontsplit is close to the end. but if height is specified then i shouldn't be using that buffer.

i've marked as a bug and will try to fix in the next release