Skip to content

lastNeverTallest option causes endless loop, crashes page #8

@thezerobit

Description

@thezerobit

This code:

if(options.lastNeverTallest && lastIsMax){
    // the last column is the tallest
    // so allow columns to be taller
    // and retry
    targetHeight = targetHeight + 30;
    if(loopCount == maxLoops-1) maxLoops++;
}

easily causes the surrounding loop to continue forever as it always puts the one element into the last column, so lastIsMax is always true, so the loop continues forever. changing the targetHeight does not change anything. This crashes Firefox and crashes the tab in Chrome.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions