Merged
Conversation
Contributor
Author
|
Can confirm, after I forked this and created my own release I was able to access the proper bower.json information you already have in place. Please make a new release on Github so people pulling via Bower can get the updated info which improves its modularity for Browserify and the like! |
Owner
|
Thanks! |
Owner
|
just posted a new release as well pointing to this commit. I'm not a bower users, so lmk if this didn't do the trick for some reason |
Contributor
Author
|
Awesome, I'll switch over to yours tomorrow when I return to my desk! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply matches the .js file number with the release number to avoid confusion. Also, while version 1.6.2 is the latest version since last November the only version available on Bower is 1.6.1. I'm not sure which version addresses this because of the version mismatch but:
When I download your plugin from Bower I get a .bower.json file that lacks a "main" key which means when trying to use Browserify it can't find the actual JS file. The solution in my eyes is to make a new release from 1.6.1 to 1.6.2. Perhaps this will carry over the change you've already made and update it on Bower.