Correctly test for whitespace-only nodeValues#205
Merged
adamwulf merged 1 commit intoadamwulf:masterfrom Dec 8, 2015
Merged
Conversation
As written, a nodeValue of "test test" will return True which appears to be the incorrect behavior. I believe only empty nodeValues and nodes that only have whitespace characters should return True. This fix looks for any non-whitespace characters in nodeValue and only returns True if none are found.
adamwulf
added a commit
that referenced
this pull request
Dec 8, 2015
Correctly test for whitespace-only nodeValues
Owner
|
good catch - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written, a nodeValue of "test test" will return True which appears to be the incorrect behavior. I believe only empty nodeValues and nodes that only have whitespace characters should return True.
This fix looks for any non-whitespace characters in nodeValue and only returns True if none are found.