Added preserving thead and tfoot in tables - Issue #180#219
Merged
adamwulf merged 5 commits intoadamwulf:masterfrom Apr 3, 2017
Merged
Added preserving thead and tfoot in tables - Issue #180#219adamwulf merged 5 commits intoadamwulf:masterfrom
adamwulf merged 5 commits intoadamwulf:masterfrom
Conversation
In the columnize function we can check weather we are in a table by testing the first child of $pullOutHere If we are in a table we can clone a copy of the <thead> and <tfoot> if they exist and store thim in the columnize function that is operating on the table. When we get to splitting the last element we add the <thead> and <tfoot> back to the table in the content source element $pullOutHere
Owner
|
Awesome - this is a great idea. Can you add a test/sample.html that shows it in action and acts as a test case for it? It'd be interesting to see a test on nested tables as well. |
Contributor
Author
|
I have added a couple of sample pages to show the behaviour. |
Owner
|
awesome thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the columnize function we can check weather we are in a table by testing the first child of $pullOutHere
If we are in a table we can clone a copy of the and if they exist and store thim in the columnize function that is operating on the table.
When we get to splitting the last element we add the and back to the table in the content source element $pullOutHere