Skip to content

docs(progressbar): enable side label control #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

docs(progressbar): enable side label control #3992

merged 1 commit into from
Jun 25, 2025
+14 −2

Conversation

marissahuysentruyt
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt commented Jun 25, 2025 •
edited
Loading

Description

We noticed that the side label variant for progress bar was only surfaced in our Chromatic tests. Upon some closer inspection, we found a code comment that said we could turn on the side label control for S2 (Spectrum 1 didn't support side labels, according to our design docs).

This PR enables the labelPosition Storybook control and adds a story to the docs page.

NOTE: No changeset is needed since no CSS was changed (we already had CSS support for side labels- this PR just added a story to our docs and enabled the control officially for S2).

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Pull down the branch to run locally or visit the deploy preview
  • Visit the progress bar docs page.
  • Verify a side label story is present and the documentation/description makes sense and is free of grammatical errors.
  • Visit the default progress bar story.
  • Verify the labelPosition control is rendering in the control table.
  • Select the side option in the labelPosition dropdown and verify the story changes as expected.
  • Verify no changes in the test grid have been introduced.
  • If you want, you can also double check that the code comment has been removed from progressbar.stories.js.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@marissahuysentruyt marissahuysentruyt self-assigned this Jun 25, 2025
@marissahuysentruyt marissahuysentruyt added documentation Because documentation is important and shouldn't be broken size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action) S2 Spectrum 2 labels Jun 25, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 89faba9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025 •
edited
Loading

File metrics

Summary

Total size: 1.42 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025 •
edited
Loading

📚 Branch preview

PR #3992 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3992/index.html.

@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/progress-bar-enable-side-label branch from ebb3585 to 89faba9 Compare June 25, 2025 18:32
@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review June 25, 2025 18:36
@castastrophe castastrophe merged commit deda056 into spectrum-two Jun 25, 2025
26 checks passed
@castastrophe castastrophe deleted the marissahuysentruyt/progress-bar-enable-side-label branch June 25, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

@aramos-adobe aramos-adobe aramos-adobe approved these changes

Assignees

@marissahuysentruyt marissahuysentruyt

Labels
documentation Because documentation is important and shouldn't be broken ready-for-review S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. skip_vrt Add to a PR to skip running VRT (but still pass the action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marissahuysentruyt @castastrophe @aramos-adobe