fix(popover): implement missing border width custom property #3995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c62db7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
File metricsSummaryTotal size: 1.42 MB*
popover
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
Contributor
📚 Branch previewPR #3995 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-3995/index.html. |
- defines the missing `--spectrum-popover-border-width` custom property - create changeset - update metadata
7634baa to
c62db7c
Compare
castastrophe
approved these changes
Jun 26, 2025
| --spectrum-popover-animation-distance: var(--spectrum-spacing-100); | ||
|
|
||
| --spectrum-popover-background-color: var(--spectrum-background-layer-2-color); | ||
| --spectrum-popover-border-width: var(--spectrum-border-width-100); |
rise-erpelding
approved these changes
Jun 26, 2025
3 tasks
Merged
11 tasks
This was referenced Aug 27, 2025
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--spectrum-popover-border-widthcustom propertyThis PR redefines a missing custom property for the popover border width. This fixes the popover positioning when the
withTipargument is true.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
--spectrum-popover-border-widthis defined in the browser styles.margin-block-endstyle has a fully defined calc.Regression testing
Validate:
Screenshots
⛔ Before
✅ After
To-do list