Revert " Fixes commons-app#2888: First time ever tapping "Nearby": Tab does not show"

ahmedmamdouh13 · ahmedmamdouh13 · commit 9c8c93ff2cfd · 2019-04-22T06:55:36.000+02:00
This reverts commit 3e44986
diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java
@@ -479,8 +479,6 @@ public void onRequestPermissionsResult(int requestCode,
                     Timber.d("Location permission given");
                     ((ContributionsFragment)contributionsActivityPagerAdapter
                             .getItem(0)).locationManager.registerLocationManager();
-                    ((NearbyFragment)contributionsActivityPagerAdapter
-                            .getItem(1)).onTabSelected(onOrientationChanged);
                 } else {
                     // If nearby fragment is visible and location permission is not given, send user back to contrib fragment
                     if (!isContributionsFragmentVisible) {
diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyFragment.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyFragment.java
@@ -41,8 +41,6 @@
 import fr.free.nrw.commons.utils.ViewUtil;
 import fr.free.nrw.commons.wikidata.WikidataEditListener;
 import io.reactivex.Observable;
-import io.reactivex.Single;
-import io.reactivex.SingleObserver;
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.schedulers.Schedulers;
 import timber.log.Timber;
@@ -604,13 +602,7 @@ private void registerLocationUpdates() {
      */
     private void requestLocationPermissions() {
         if (!getActivity().isFinishing()) {
-            new Single<Object>(){
-                @Override
-                protected void subscribeActual(SingleObserver<? super Object> observer) {
-                    locationManager.requestPermissions(getActivity());
-                }
-            }.subscribeOn(Schedulers.newThread())
-            .subscribe();
+            locationManager.requestPermissions(getActivity());
         }
     }
 
