Skip to content

First time ever tapping "Nearby": Tab does not show #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-raoul opened this issue Apr 17, 2019 · 5 comments · Fixed by #2925
Closed

First time ever tapping "Nearby": Tab does not show #2888

nicolas-raoul opened this issue Apr 17, 2019 · 5 comments · Fixed by #2925
Labels
bug nearby

Comments

@nicolas-raoul
Copy link
Member

Steps to reproduce:

  1. Install app on new phone
  2. Log in
  3. Tap "nearby"
  4. Location permission popup appear, accept
  5. Nearby tab is not opened (nearest location bar is shown, though)

Workaround: Tap on "Nearby" again.

Commons app version:
2.10.2-debug-master~84637c5fe

Screen-shots:
Screenshot from 2019-04-17 17-38-54
@ahmedmamdouh13
Copy link

requesting location permission off the main thread seems to solve the problem , but still loading forever after permission being granted , i'm on it.

@nicolas-raoul
Copy link
Member Author

@ahmedmamdouh13 Assigned to you, thanks! :-)

@ahmedmamdouh13
Copy link

in what format should i upload videos , i couldn't upload but gif

ezgif com-video-to-gif

@nicolas-raoul
Copy link
Member Author

I don't think GitHub accepts videos formats, except GIF

ahmedmamdouh13 added a commit to ahmedmamdouh13/apps-android-commons that referenced this issue Apr 19, 2019
@ahmedmamdouh13
Fixes commons-app#2888: First time ever tapping "Nearby": Tab does n…
3e44986 
…ot show
@ahmedmamdouh13
Copy link

untitled

@ahmedmamdouh13 ahmedmamdouh13 mentioned this issue Apr 20, 2019
Closed
ahmedmamdouh13 added a commit to ahmedmamdouh13/apps-android-commons that referenced this issue Apr 22, 2019
@ahmedmamdouh13
Fixes commons-app#2888: dispose of the single
4db28e8
ahmedmamdouh13 added a commit to ahmedmamdouh13/apps-android-commons that referenced this issue Apr 22, 2019
@ahmedmamdouh13
Revert " Fixes commons-app#2888: First time ever tapping "Nearby": Ta…
9c8c93f 
…b does not show"

This reverts commit 3e44986
@maskaravivek maskaravivek mentioned this issue Apr 24, 2019
Merged
neslihanturan pushed a commit that referenced this issue Jun 8, 2019
@maskaravivek @neslihanturan
Fixes #2888: Use Dexter for requesting location permissions (#2925)
8971743 
* Use dexter to ask for location permissions

* Addressed code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug nearby
Projects
None yet
Milestone
No milestone
2 participants
@nicolas-raoul @ahmedmamdouh13