Advise against @extend, enable SCSS-lint ExtendDirective #8
Conversation
README.md
Outdated
There was a problem hiding this comment.
did you intend to remove the mixins section entirely?
There was a problem hiding this comment.
We should keep this section but reword the description. In the wake of advising against @extend, this section should recommend using mixins to DRY up code if you are also serving gzip'd code. We should maintain a note that using mixins without arguments can lead to unnecessary code duplication if you aren't gzipping.
There was a problem hiding this comment.
Yeah, I removed it because it only recommended against using argumentless mixins in favor of extending placeholders. I'll push a new revision that improves this section.
|
<3 |
In my previous commit, I revised this document to advise against using @extend, which included removing the section about mixins because it only existed to recommend against using argumentless mixins in favor of @extend. However, this document feels a bit incomplete without some guidance on mixin usage, so I am adding a few sentences here.
|
Alright folks, I added a section about mixins. Feedback away! |
|
👌 |
|
LGTM2 |
|
Great, if we are all good, will someone please merge? I don't appear to have access. |
Advise against @extend, enable SCSS-lint ExtendDirective
@extend is unintuitive and dangerous, so we are recommending against its
use. As part of this commit, I enabled the SCSS-lint linter that will
warn against its use. I also revised content that mentioned @extend, to
maintain philosophical consistency.