Closes commons-app#3264, disable options menu for null media from provider (commons-app#3265)

Author: ashishkumar468

app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java

@@ -1,5 +1,9 @@
 package fr.free.nrw.commons.media;
 
+import static android.Manifest.permission.WRITE_EXTERNAL_STORAGE;
+import static android.content.Context.DOWNLOAD_SERVICE;
+import static fr.free.nrw.commons.Utils.handleWebUrl;
+
 import android.annotation.SuppressLint;
 import android.app.DownloadManager;
 import android.content.Intent;
@@ -14,15 +18,10 @@
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.Toast;
-
 import androidx.fragment.app.Fragment;
 import androidx.fragment.app.FragmentManager;
 import androidx.fragment.app.FragmentStatePagerAdapter;
 import androidx.viewpager.widget.ViewPager;
-
-import javax.inject.Inject;
-import javax.inject.Named;
-
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import fr.free.nrw.commons.Media;
@@ -42,12 +41,10 @@
 import fr.free.nrw.commons.utils.NetworkUtils;
 import fr.free.nrw.commons.utils.PermissionUtils;
 import fr.free.nrw.commons.utils.ViewUtil;
+import javax.inject.Inject;
+import javax.inject.Named;
 import timber.log.Timber;
 
-import static android.Manifest.permission.WRITE_EXTERNAL_STORAGE;
-import static android.content.Context.DOWNLOAD_SERVICE;
-import static fr.free.nrw.commons.Utils.handleWebUrl;
-
 public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment implements ViewPager.OnPageChangeListener {
 
     @Inject SessionManager sessionManager;
@@ -256,6 +253,7 @@ public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
                     menu.findItem(R.id.menu_share_current_image).setEnabled(true).setVisible(true);
                     menu.findItem(R.id.menu_download_current_image).setEnabled(true).setVisible(true);
                     menu.findItem(R.id.menu_bookmark_current_image).setEnabled(true).setVisible(true);
+                    menu.findItem(R.id.menu_set_as_wallpaper).setEnabled(true).setVisible(true);
 
                     // Initialize bookmark object
                     bookmark = new Bookmark(
@@ -265,27 +263,39 @@ public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
                     );
                     updateBookmarkState(menu.findItem(R.id.menu_bookmark_current_image));
 
-                    if (m instanceof Contribution ) {
+                    if (m instanceof Contribution) {
                         Contribution c = (Contribution) m;
                         switch (c.getState()) {
                             case Contribution.STATE_FAILED:
-                                menu.findItem(R.id.menu_browser_current_image).setEnabled(false).setVisible(false);
-                                menu.findItem(R.id.menu_share_current_image).setEnabled(false).setVisible(false);
-                                menu.findItem(R.id.menu_download_current_image).setEnabled(false).setVisible(false);
-                                menu.findItem(R.id.menu_bookmark_current_image).setEnabled(false).setVisible(false);
-                                break;
                             case Contribution.STATE_IN_PROGRESS:
                             case Contribution.STATE_QUEUED:
-                                menu.findItem(R.id.menu_browser_current_image).setEnabled(false).setVisible(false);
-                                menu.findItem(R.id.menu_share_current_image).setEnabled(false).setVisible(false);
-                                menu.findItem(R.id.menu_download_current_image).setEnabled(false).setVisible(false);
-                                menu.findItem(R.id.menu_bookmark_current_image).setEnabled(false).setVisible(false);
+                                menu.findItem(R.id.menu_browser_current_image).setEnabled(false)
+                                        .setVisible(false);
+                                menu.findItem(R.id.menu_share_current_image).setEnabled(false)
+                                        .setVisible(false);
+                                menu.findItem(R.id.menu_download_current_image).setEnabled(false)
+                                        .setVisible(false);
+                                menu.findItem(R.id.menu_bookmark_current_image).setEnabled(false)
+                                        .setVisible(false);
+                                menu.findItem(R.id.menu_set_as_wallpaper).setEnabled(false)
+                                        .setVisible(false);
                                 break;
                             case Contribution.STATE_COMPLETED:
                                 // Default set of menu items works fine. Treat same as regular media object
                                 break;
                         }
                     }
+                } else {
+                    menu.findItem(R.id.menu_browser_current_image).setEnabled(false)
+                            .setVisible(false);
+                    menu.findItem(R.id.menu_share_current_image).setEnabled(false)
+                            .setVisible(false);
+                    menu.findItem(R.id.menu_download_current_image).setEnabled(false)
+                            .setVisible(false);
+                    menu.findItem(R.id.menu_bookmark_current_image).setEnabled(false)
+                            .setVisible(false);
+                    menu.findItem(R.id.menu_set_as_wallpaper).setEnabled(false)
+                            .setVisible(false);
                 }
             }
         }