Skip to content

Conversation

@ashishkumar468
Copy link
Collaborator

Description (required)

Fixes NPE in MediaDetailFragment #3264

What changes did you make and why?
Disable options menu for null media from Provider

Tests performed (required)

Tested {ProdDebug} on {One Plus 3} with API level {27}.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

Codecov Report

Merging #3265 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3265      +/-   ##
=========================================
- Coverage    6.54%   6.53%   -0.01%     
=========================================
  Files         270     270              
  Lines       11613   11626      +13     
  Branches      906     906              
=========================================
  Hits          760     760              
- Misses      10793   10806      +13     
  Partials       60      60
Impacted Files Coverage Δ
...ee/nrw/commons/media/MediaDetailPagerFragment.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9e792...2227091. Read the comment docs.

@misaochan misaochan merged commit 1359f70 into commons-app:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants