Remove unused code from the app (commons-app#3276)

Author: maskaravivek

app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java

@@ -6,7 +6,6 @@
 import javax.inject.Singleton;
 
 import fr.free.nrw.commons.media.MediaClient;
-import fr.free.nrw.commons.mwapi.OkHttpJsonApiClient;
 import io.reactivex.Single;
 import timber.log.Timber;
 
@@ -18,13 +17,10 @@
  */
 @Singleton
 public class MediaDataExtractor {
-    private final OkHttpJsonApiClient okHttpJsonApiClient;
     private final MediaClient mediaClient;
 
     @Inject
-    public MediaDataExtractor(OkHttpJsonApiClient okHttpJsonApiClient,
-                              MediaClient mediaClient) {
-        this.okHttpJsonApiClient = okHttpJsonApiClient;
+    public MediaDataExtractor(MediaClient mediaClient) {
         this.mediaClient = mediaClient;
     }
 

app/src/main/java/fr/free/nrw/commons/achievements/Achievements.java

@@ -5,9 +5,7 @@
  */
 public class Achievements {
     private int uniqueUsedImages;
-    private int articlesUsingImages;
     private int thanksReceived;
-    private int imagesEditedBySomeoneElse;
     private int featuredImages;
     private int imagesUploaded;
     private int revertCount;
@@ -19,24 +17,18 @@ public Achievements(){
     /**
      * constructor for achievements class to set its data members
      * @param uniqueUsedImages
-     * @param articlesUsingImages
      * @param thanksReceived
-     * @param imagesEditedBySomeoneElse
      * @param featuredImages
      * @param imagesUploaded
      * @param revertCount
      */
     public Achievements(int uniqueUsedImages,
-                        int articlesUsingImages,
                         int thanksReceived,
-                        int imagesEditedBySomeoneElse,
                         int featuredImages,
                         int imagesUploaded,
                         int revertCount) {
         this.uniqueUsedImages = uniqueUsedImages;
-        this.articlesUsingImages = articlesUsingImages;
         this.thanksReceived = thanksReceived;
-        this.imagesEditedBySomeoneElse = imagesEditedBySomeoneElse;
         this.featuredImages = featuredImages;
         this.imagesUploaded = imagesUploaded;
         this.revertCount = revertCount;
@@ -50,9 +42,7 @@ public Achievements(int uniqueUsedImages,
      */
     public static Achievements from(FeedbackResponse response) {
         return new Achievements(response.getUniqueUsedImages(),
-                response.getArticlesUsingImages(),
                 response.getThanksReceived(),
-                response.getImagesEditedBySomeoneElse(),
                 response.getFeaturedImages().getQualityImages()
                         + response.getFeaturedImages().getFeaturedPicturesOnWikimediaCommons(),
                 0,
@@ -99,54 +89,6 @@ public void setImagesUploaded(int imagesUploaded) {
         this.imagesUploaded = imagesUploaded;
     }
 
-    /**
-     * setter function to set count of featured images
-     * @param featuredImages
-     */
-    public void setFeaturedImages(int featuredImages) {
-        this.featuredImages = featuredImages;
-    }
-
-    /**
-     * setter function to set the count of images edited by someone
-     * @param imagesEditedBySomeoneElse
-     */
-    public void setImagesEditedBySomeoneElse(int imagesEditedBySomeoneElse) {
-        this.imagesEditedBySomeoneElse = imagesEditedBySomeoneElse;
-    }
-
-    /**
-     * setter function to set count of thanks received
-     * @param thanksReceived
-     */
-    public void setThanksReceived(int thanksReceived) {
-        this.thanksReceived = thanksReceived;
-    }
-
-    /**
-     * setter function to count of articles using images uploaded
-     * @param articlesUsingImages
-     */
-    public void setArticlesUsingImages(int articlesUsingImages) {
-        this.articlesUsingImages = articlesUsingImages;
-    }
-
-    /**
-     * setter function to set count of uniques images used by wiki
-     * @param uniqueUsedImages
-     */
-    public void setUniqueUsedImages(int uniqueUsedImages) {
-        this.uniqueUsedImages = uniqueUsedImages;
-    }
-
-    /**
-     * to set count of images reverted
-     * @param revertCount
-     */
-    public void setRevertCount(int revertCount) {
-        this.revertCount = revertCount;
-    }
-
     /**
      * used to calculate the percentages of images that haven't been reverted
      * @return

app/src/main/java/fr/free/nrw/commons/achievements/FeedbackResponse.java

@@ -2,36 +2,26 @@
 
 public class FeedbackResponse {
 
-    private final String status;
     private final int uniqueUsedImages;
     private final int articlesUsingImages;
     private final int deletedUploads;
     private final FeaturedImages featuredImages;
     private final int thanksReceived;
     private final String user;
-    private final int imagesEditedBySomeoneElse;
 
 
-    public FeedbackResponse(String status,
-                            int uniqueUsedImages,
+    public FeedbackResponse(int uniqueUsedImages,
                             int articlesUsingImages,
                             int deletedUploads,
                             FeaturedImages featuredImages,
                             int thanksReceived,
-                            String user,
-                            int imagesEditedBySomeoneElse) {
-        this.status = status;
+                            String user) {
         this.uniqueUsedImages = uniqueUsedImages;
         this.articlesUsingImages = articlesUsingImages;
         this.deletedUploads = deletedUploads;
         this.featuredImages = featuredImages;
         this.thanksReceived = thanksReceived;
         this.user = user;
-        this.imagesEditedBySomeoneElse = imagesEditedBySomeoneElse;
-    }
-
-    public String getStatus() {
-        return status;
     }
 
     public int getUniqueUsedImages() {
@@ -58,7 +48,4 @@ public String getUser() {
         return user;
     }
 
-    public int getImagesEditedBySomeoneElse() {
-        return imagesEditedBySomeoneElse;
-    }
 }

app/src/main/java/fr/free/nrw/commons/auth/AccountUtil.java

@@ -10,7 +10,6 @@
 
 public class AccountUtil {
 
-    public static final String AUTH_COOKIE = "authCookie";
     public static final String AUTH_TOKEN_TYPE = "CommonsAndroid";
 
     public AccountUtil() {
@@ -38,12 +37,6 @@ public static String getUserName(Context context) {
         return account == null ? null : account.name;
     }
 
-    @Nullable
-    public static String getPassword(Context context) {
-        Account account = account(context);
-        return account == null ? null : accountManager(context).getPassword(account);
-    }
-
     private static AccountManager accountManager(Context context) {
         return AccountManager.get(context);
     }

app/src/main/java/fr/free/nrw/commons/auth/WikiAccountAuthenticator.java

@@ -9,6 +9,7 @@
 import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
+
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
@@ -109,16 +110,6 @@ private Bundle addAccount(AccountAuthenticatorResponse response) {
         return bundle;
     }
 
-    private Bundle unsupportedOperation() {
-        Bundle bundle = new Bundle();
-        bundle.putInt(AccountManager.KEY_ERROR_CODE, AccountManager.ERROR_CODE_UNSUPPORTED_OPERATION);
-
-        // HACK: the docs indicate that this is a required key bit it's not displayed to the user.
-        bundle.putString(AccountManager.KEY_ERROR_MESSAGE, "");
-
-        return bundle;
-    }
-
     @Override
     public Bundle getAccountRemovalAllowed(AccountAuthenticatorResponse response,
                                            Account account) throws NetworkErrorException {

app/src/main/java/fr/free/nrw/commons/bookmarks/Bookmark.java

@@ -40,11 +40,4 @@ public Uri getContentUri() {
         return contentUri;
     }
 
-    /**
-     * Modifies the content URI - marking this bookmark as already saved in the database
-     * @param contentUri the content URI
-     */
-    public void setContentUri(Uri contentUri) {
-        this.contentUri = contentUri;
-    }
 }

app/src/main/java/fr/free/nrw/commons/category/CategoriesAdapterFactory.java

@@ -120,10 +120,6 @@ public void writeToParcel(Parcel parcel, int flags) {
         parcel.writeInt(isMultiple ? 1 : 0);
     }
 
-    public String getDateCreatedSource() {
-        return dateCreatedSource;
-    }
-
     public void setDateCreatedSource(String dateCreatedSource) {
         this.dateCreatedSource = dateCreatedSource;
     }
@@ -241,14 +237,6 @@ public void setSource(String source) {
         this.source = source;
     }
 
-    public void setLocalUri(Uri localUri) {
-        this.localUri = localUri;
-    }
-
-    public void setDecimalCoords(String decimalCoords) {
-        this.decimalCoords = decimalCoords;
-    }
-
     @NonNull
     private String licenseTemplateFor(String license) {
         switch (license) {
@@ -284,7 +272,4 @@ public void setContentProviderUri(Uri contentProviderUri) {
         this.contentProviderUri = contentProviderUri;
     }
 
-    public Uri getContentProviderUri() {
-        return contentProviderUri;
-    }
 }

app/src/main/java/fr/free/nrw/commons/category/CategoryRendererAdapter.java

@@ -1,28 +1,28 @@
 package fr.free.nrw.commons.contributions;
 
-import static fr.free.nrw.commons.contributions.Contribution.STATE_FAILED;
-import static fr.free.nrw.commons.contributions.MainActivity.CONTRIBUTIONS_TAB_POSITION;
-import static fr.free.nrw.commons.utils.LengthUtils.formatDistanceBetween;
-
 import android.Manifest;
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.content.ServiceConnection;
-import android.database.DataSetObserver;
 import android.os.Bundle;
 import android.os.IBinder;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.CheckBox;
 import android.widget.Toast;
+
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.fragment.app.Fragment;
 import androidx.fragment.app.FragmentManager;
 import androidx.fragment.app.FragmentManager.OnBackStackChangedListener;
 import androidx.fragment.app.FragmentTransaction;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
 import butterknife.BindView;
 import butterknife.ButterKnife;
 import fr.free.nrw.commons.HandlerService;
@@ -56,11 +56,12 @@
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.disposables.CompositeDisposable;
 import io.reactivex.schedulers.Schedulers;
-import java.util.ArrayList;
-import javax.inject.Inject;
-import javax.inject.Named;
 import timber.log.Timber;
 
+import static fr.free.nrw.commons.contributions.Contribution.STATE_FAILED;
+import static fr.free.nrw.commons.contributions.MainActivity.CONTRIBUTIONS_TAB_POSITION;
+import static fr.free.nrw.commons.utils.LengthUtils.formatDistanceBetween;
+
 public class ContributionsFragment
         extends CommonsDaggerSupportFragment
         implements
@@ -76,7 +77,6 @@ public class ContributionsFragment
     @Inject CampaignsPresenter presenter;
     @Inject LocationServiceManager locationManager;
 
-    private ArrayList<DataSetObserver> observersWaitingForLoad = new ArrayList<>();
     private UploadService uploadService;
     private boolean isUploadServiceConnected;
     private CompositeDisposable compositeDisposable = new CompositeDisposable();
@@ -371,10 +371,6 @@ private void displayUploadCount(Integer uploadCount) {
 
     }
 
-    public void betaSetUploadCount(int betaUploadCount) {
-        displayUploadCount(betaUploadCount);
-    }
-
     @Override
     public void onPause() {
         super.onPause();