Skip to content

Conversation

@maskaravivek
Copy link
Contributor

No description provided.

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@bb0a219). Click here to learn what that means.
The diff coverage is 20%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #3276   +/-   ##
========================================
  Coverage          ?    7.4%           
========================================
  Files             ?     266           
  Lines             ?   11398           
  Branches          ?     892           
========================================
  Hits              ?     844           
  Misses            ?   10492           
  Partials          ?      62
Impacted Files Coverage Δ
...ommons/contributions/ContributionsSyncAdapter.java 0% <ø> (ø)
...fr/free/nrw/commons/achievements/Achievements.java 0% <ø> (ø)
...r/free/nrw/commons/contributions/Contribution.java 0.94% <ø> (ø)
...c/main/java/fr/free/nrw/commons/utils/UiUtils.java 0% <ø> (ø)
...ain/java/fr/free/nrw/commons/auth/AccountUtil.java 0% <ø> (ø)
...in/java/fr/free/nrw/commons/utils/LayoutUtils.java 0% <ø> (ø)
...ain/java/fr/free/nrw/commons/utils/PlaceUtils.java 0% <ø> (ø)
...rw/commons/filepicker/FilePickerConfiguration.java 0% <ø> (ø)
...ava/fr/free/nrw/commons/filepicker/FilePicker.java 0% <ø> (ø)
...e/nrw/commons/location/LocationServiceManager.java 0% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0a219...9a58b9a. Read the comment docs.

@ashishkumar468 ashishkumar468 merged commit 2f9a719 into commons-app:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants