Merge pull request commons-app#1211 from tshradheya/1195-give-toast-message

Give toast when trying to upload image without giving a Title commons-app#1195

Author: Vivek Maskara

app/src/main/java/fr/free/nrw/commons/upload/SingleUploadFragment.java

@@ -28,6 +28,7 @@
 import android.widget.EditText;
 import android.widget.Spinner;
 import android.widget.TextView;
+import android.widget.Toast;
 
 import java.util.ArrayList;
 
@@ -65,9 +66,6 @@ public class SingleUploadFragment extends CommonsDaggerSupportFragment {
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
         inflater.inflate(R.menu.activity_share, menu);
-        if (titleEdit != null) {
-            menu.findItem(R.id.menu_upload_single).setEnabled(titleEdit.getText().length() != 0);
-        }
     }
 
     @Override
@@ -76,6 +74,11 @@ public boolean onOptionsItemSelected(MenuItem item) {
             //What happens when the 'submit' icon is tapped
             case R.id.menu_upload_single:
 
+                if (titleEdit.getText().toString().isEmpty()) {
+                    Toast.makeText(getContext(), R.string.add_title_toast, Toast.LENGTH_LONG).show();
+                    return false;
+                }
+
                 String title = titleEdit.getText().toString();
                 String desc = descEdit.getText().toString();
 

app/src/main/res/menu/activity_share.xml

@@ -3,6 +3,6 @@
     <item android:id="@+id/menu_upload_single"
         android:title="@string/menu_upload_single"
         android:icon="@drawable/ic_send_white_24dp"
-        android:enabled="false"
+        android:enabled="true"
         app:showAsAction="always" />
 </menu>

app/src/main/res/values/strings.xml

@@ -38,6 +38,7 @@
   <string name="menu_share">Share</string>
   <string name="menu_open_in_browser">View in Browser</string>
   <string name="share_title_hint">Title</string>
+  <string name="add_title_toast">Please give a Title to proceed</string>
   <string name="share_description_hint">Description</string>
   <string name="login_failed_network">Unable to login - network failure</string>
   <string name="login_failed_username">Unable to login - please check your username</string>