Give toast when trying to upload image without giving a Title #1195

[tshradheya]

Description

Fixes #1195

Outline of Soultion

• Made submit button always enabled. Before it was disabled when title was empty and it wasn't intuitive to user as to what is happening on click when title is empty
• Whenever the submit button is clicked with title empty a toast is shown as in screenshot

Screenshots showing what changed

[codecov-io]

Codecov Report

Merging #1211 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1211      +/-   ##
=========================================
- Coverage    3.82%   3.82%   -0.01%     
=========================================
  Files         125     125              
  Lines        5810    5811       +1     
  Branches      568     567       -1     
=========================================
  Hits          222     222              
- Misses       5573    5574       +1     
  Partials       15      15

Impacted Files	Coverage Δ
.../free/nrw/commons/upload/SingleUploadFragment.java	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215c97e...6a05231. Read the comment docs.

[tshradheya]

@neslihanturan Could you review this as you have reviewed my PR's before?

[neslihanturan]

@tshradheya currently it works exactly as intended.
Giving disabled design to send button is also an approach. Currently it is meaningless because it looks same when it is disabled or enabled. I think this approach is more expected and familiar. What do you think?

And what everyone else think? If any one agrees with the strategy implemented here, I will merge.

[tshradheya]

While trying to find a solution to this, initially I was unaware that the button was disabled cause it looked exactly the same to me. This is not very good for users cause they can still press the button but see no response.

I feel the current solution is better cause

1. The button is always enabled so it always responds
2. Giving a toast makes the instruction clear

[maskaravivek]

We can probably have this fix for now and maybe take up the enabled/disabled design later.

[tshradheya]

@maskaravivek @neslihanturan Any update on this?

[tshradheya]

Sorry for bothering.
This PR is ready for review :)

[maskaravivek]

LGTM. @tshradheya Sorry for the delay in reviewing your diff.

Hope you understand that we are also just volunteers and we do it in the free time. Moreover recently the project has been getting a lot of attention, so there's a lot of things to take care of. :)

[misaochan]

Sorry for the late comment, but "Please give a Title to proceed" feels slightly off to me. Perhaps "Please provide a title for this file" (without the capital T) might be better?

[neslihanturan]

Should we revert @misaochan ?

[tshradheya]

I will just create another PR to quickly fix the message