Skip to content

Commit b017d1c

Browse files
ujjwalagrawal17neslihanturan
authored andcommitted
Changed webview to Custom Tabs in Settings Page (commons-app#1328)
* Changed Webview to Custoom tabs in Settings Page * Get COntext changed to getActivity
1 parent 5ebaa74 commit b017d1c

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,11 @@ public void onCreate(Bundle savedInstanceState) {
102102
return true;
103103
});
104104

105+
Preference betaTesterPreference = findPreference("becomeBetaTester");
106+
betaTesterPreference.setOnPreferenceClickListener(preference -> {
107+
Utils.handleWebUrl(getActivity(),Uri.parse(getResources().getString(R.string.beta_opt_in_link)));
108+
return true;
109+
});
105110
Preference sendLogsPreference = findPreference("sendLogFile");
106111
sendLogsPreference.setOnPreferenceClickListener(preference -> {
107112
//first we need to check if we have the necessary permissions

app/src/main/res/xml/preferences.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@
5252
<PreferenceCategory
5353
android:title="@string/preference_category_feedback">
5454

55-
<Preference android:title="@string/become_a_tester_title"
55+
<Preference
56+
android:key="becomeBetaTester"
57+
android:title="@string/become_a_tester_title"
5658
android:summary="@string/become_a_tester_description">
57-
<intent android:action="android.intent.action.VIEW"
58-
android:data="@string/beta_opt_in_link" />
5959
</Preference>
6060

6161
<Preference

0 commit comments

Comments
 (0)