Skip to content

Conversation

@ujjwalagrawal17
Copy link
Contributor

@ujjwalagrawal17 ujjwalagrawal17 commented Mar 18, 2018

Description

Fixes #1143

  1. Changed webview to Custom Tabs in "become beta tester" preference.

Tests performed

Manually Tested on MotoG5S+ {Android 7.1.1}, with {build variant-Debug}.

@codecov-io
Copy link

codecov-io commented Mar 18, 2018

Codecov Report

Merging #1328 into master will decrease coverage by 0.6%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1328      +/-   ##
=========================================
- Coverage    3.81%   3.21%   -0.61%     
=========================================
  Files         126     132       +6     
  Lines        5919    7090    +1171     
  Branches      583     682      +99     
=========================================
+ Hits          226     228       +2     
- Misses       5678    6847    +1169     
  Partials       15      15
Impacted Files Coverage Δ
...fr/free/nrw/commons/settings/SettingsFragment.java 29.62% <0%> (+1.05%) ⬆️
.../free/nrw/commons/di/CommonsApplicationModule.java 50% <0%> (-2.64%) ⬇️
...main/java/fr/free/nrw/commons/location/LatLng.java 52.77% <0%> (-1.51%) ⬇️
...free/nrw/commons/theme/NavigationBaseActivity.java 22.82% <0%> (-0.77%) ⬇️
.../java/fr/free/nrw/commons/auth/SessionManager.java 16.66% <0%> (-0.48%) ⬇️
...rw/commons/mwapi/ApacheHttpClientMediaWikiApi.java 5.49% <0%> (-0.32%) ⬇️
...fr/free/nrw/commons/media/MediaDetailFragment.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/category/CategoryDao.java 0% <0%> (ø) ⬆️
...java/fr/free/nrw/commons/upload/ShareActivity.java 0% <0%> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80cc8b7...81ef8e1. Read the comment docs.

@ujjwalagrawal17
Copy link
Contributor Author

@neslihanturan Can you review this PR.

@neslihanturan
Copy link
Collaborator

It crashes on API level 19:

java.lang.NoSuchMethodError: fr.free.nrw.commons.settings.SettingsFragment.getContext
                                                                               at fr.free.nrw.commons.settings.SettingsFragment.lambda$onCreate$4$SettingsFragment(SettingsFragment.java:107)

Since getcontext call requires API level 23, our min is 15

@tanvidadu
Copy link
Contributor

changing getcontext() to getActivity() would work !

@neslihanturan
Copy link
Collaborator

Thanks @ujjwalagrawal17 !

@neslihanturan neslihanturan merged commit b017d1c into commons-app:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants