Use Timber.e(Throwable t, String message, Object... args) (commons-app#2582)

Author: whym

app/src/main/java/fr/free/nrw/commons/MediaDataExtractor.java

@@ -66,7 +66,7 @@ public void fetch(String filename, LicenseList licenseList) throws IOException {
             Timber.d("Nominated for deletion: " + deletionStatus);
         }
         catch (Exception e){
-            Timber.d(e.getMessage());
+            Timber.d(e, "Exception during fetching");
         }
 
         MediaResult result = mediaWikiApi.fetchMediaByFilename(filename);

app/src/main/java/fr/free/nrw/commons/campaigns/CampaignsPresenter.java

@@ -107,7 +107,7 @@ public void getCampaigns() {
                     }
 
                     @Override public void onError(Throwable e) {
-                        Timber.e(e.getMessage(), "could not fetch campaigns");
+                        Timber.e(e, "could not fetch campaigns");
                     }
                 });
         }

app/src/main/java/fr/free/nrw/commons/contributions/ContributionDao.java

@@ -318,7 +318,7 @@ private static void runQuery(SQLiteDatabase db, String query) {
             try {
                 db.execSQL(query);
             } catch (SQLiteException e) {
-                Timber.e("Exception performing query: " + query + " message: " + e.getMessage());
+                Timber.e(e, "Exception performing query: " + query);
             }
         }
 

app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java

@@ -66,7 +66,7 @@ List<Place> radiusExpander(LatLng curLatLng, String lang, boolean returnClosestR
                 try {
                     places = getFromWikidataQuery(curLatLng, lang, radius);
                 } catch (InterruptedIOException e) {
-                    Timber.e(e,"exception in fetching nearby places");
+                    Timber.e(e, "exception in fetching nearby places");
                     return places;
                 }
                 Timber.d("%d results at radius: %f", places.size(), radius);