Skip to content

Use Timber.e(Throwable t, String message, Object... args) #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

whym
Copy link
Collaborator

@whym whym commented Mar 13, 2019

Description (required)

Use the appropriate variation of Timber.e for exceptions.

Some logging code use the wrong variation of Timber methods resulting in unexpected error messages. This commit fixes that.

Tests performed (required)

Tested upload function using betaDebug on emulator with API level 24, but the test didn't allow me to see error messages. The messages are kind of hard to encounter. I merely trusted the documentation.

@codecov-io
Copy link

Codecov Report

Merging #2582 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2582   +/-   ##
======================================
  Coverage    5.91%   5.91%           
======================================
  Files         258     258           
  Lines       12324   12324           
  Branches     1114    1114           
======================================
  Hits          729     729           
  Misses      11536   11536           
  Partials       59      59
Impacted Files Coverage Δ
...n/java/fr/free/nrw/commons/MediaDataExtractor.java 0% <0%> (ø) ⬆️
...ree/nrw/commons/contributions/ContributionDao.java 0% <0%> (ø) ⬆️
.../java/fr/free/nrw/commons/nearby/NearbyPlaces.java 0% <0%> (ø) ⬆️
...free/nrw/commons/campaigns/CampaignsPresenter.java 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5038876...8cd3dab. Read the comment docs.

@maskaravivek maskaravivek merged commit b5051f9 into commons-app:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants