Skip to content

Commit b8cfc5f

Browse files
committed
Revert "sidebar - fixed colapsable without href causing error"
This reverts commit 01866fc.
1 parent b7dbb0d commit b8cfc5f

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

src/js/bundle.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1680,8 +1680,7 @@ class KromaSidebar {
16801680
for(var i = 0; i < this.pages.length; i++){
16811681

16821682
var li = document.createElement('li');
1683-
//remove href from collapsable parent
1684-
if (li.querySelector('a') && element.hasAttribute('href')) {li.querySelector('a').removeAttribute('href');}
1683+
li.querySelector('a').removeAttribute('href'); //remove href from collapsable parent
16851684
li.classList.add('no-selection');
16861685

16871686
//parent page

src/js/components/sidebar.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ class KromaSidebar {
138138
for(var i = 0; i < this.pages.length; i++){
139139

140140
var li = document.createElement('li');
141-
//remove href from collapsable parent
142-
if (li.querySelector('a') && element.hasAttribute('href')) {li.querySelector('a').removeAttribute('href');}
141+
li.querySelector('a').removeAttribute('href'); //remove href from collapsable parent
143142
li.classList.add('no-selection');
144143

145144
//parent page

0 commit comments

Comments
 (0)