Skip to content

Conversation

@ofagbemi
Copy link

@ofagbemi ofagbemi changed the title Added zoom entrances and exits as per @ramatsu's request # 186 Added zoom entrances and exits as per @ramatsu's request #186 Mar 25, 2014
@daneden
Copy link
Collaborator

daneden commented Mar 28, 2014

This is pretty nice. The cushioning is a little off – try lessening how much the element is offset after the initial entrance curve (after it goes over the finishing position).

@ofagbemi
Copy link
Author

@daneden Toned it down a bit on the side entrances. How do you feel about it on the up/down entrances?

@daneden
Copy link
Collaborator

daneden commented Mar 28, 2014

The cushioning still feels off. I’d try exploring different easing types inside the keyframes. Take a look at the source for flip for inspiration.

@ofagbemi
Copy link
Author

Tried some easing on the left and right entrances. I feel alright with the up/down entrances - do you feel like the cushioning is off on those, too?

@daneden
Copy link
Collaborator

daneden commented Apr 22, 2014

It’s actually just up/down that seems off. Looks like there’s a problem merging now. Take out up/down and revisit them, and fix the merge conflicts with master, and I’ll take another look at these!

@ofagbemi
Copy link
Author

Removed the up and down zooms. I'll try to look at them again soon.

@ofagbemi
Copy link
Author

Added a little easing---I think it's a lot smoother now.

@daneden
Copy link
Collaborator

daneden commented Apr 25, 2014

Right on. Merging!

daneden added a commit that referenced this pull request Apr 25, 2014
Added zoom entrances and exits as per @ramatsu's request #186
@daneden daneden merged commit b40b961 into animate-css:master Apr 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants