Skip to content

JUnit5 assertThrows OptionTest #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 2 commits into from
Nov 11, 2022
Merged

JUnit5 assertThrows OptionTest #140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6661d7
JUnit5 Api Dependency
nhojpatrick Oct 21, 2022
0e37434
JUnit5 assertThrows OptionTest
nhojpatrick Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
JUnit5 assertThrows OptionTest
  • Loading branch information
@nhojpatrick
nhojpatrick committed Nov 11, 2022
commit 0e37434942288d40df044110cdf7c52041de7175
32 changes: 20 additions & 12 deletions src/test/java/org/apache/commons/cli/OptionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.commons.cli;

import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals;
Expand All @@ -27,6 +28,7 @@
import org.junit.Test;

public class OptionTest {

private static class DefaultOption extends Option {
private static final long serialVersionUID = 1L;

Expand Down Expand Up @@ -71,34 +73,40 @@ private static void checkOption(final Option option, final String opt, final Str
assertEquals(cls, option.getType());
}

@Test(expected = IllegalArgumentException.class)
@Test
public void testBuilderInsufficientParams1() {
Option.builder().desc("desc").build();
assertThrows(IllegalArgumentException.class, () ->
Option.builder().desc("desc").build());
}

@Test(expected = IllegalArgumentException.class)
@Test
public void testBuilderInsufficientParams2() {
Option.builder(null).desc("desc").build();
assertThrows(IllegalArgumentException.class, () ->
Option.builder(null).desc("desc").build());
}

@Test(expected = IllegalArgumentException.class)
@Test
public void testBuilderInvalidOptionName1() {
Option.builder().option("invalid?");
assertThrows(IllegalArgumentException.class, () ->
Option.builder().option("invalid?"));
}

@Test(expected = IllegalArgumentException.class)
@Test
public void testBuilderInvalidOptionName2() {
Option.builder().option("invalid@");
assertThrows(IllegalArgumentException.class, () ->
Option.builder().option("invalid@"));
}

@Test(expected = IllegalArgumentException.class)
@Test
public void testBuilderInvalidOptionName3() {
Option.builder("invalid?");
assertThrows(IllegalArgumentException.class, () ->
Option.builder("invalid?"));
}

@Test(expected = IllegalArgumentException.class)
@Test
public void testBuilderInvalidOptionName4() {
Option.builder("invalid@");
assertThrows(IllegalArgumentException.class, () ->
Option.builder("invalid@"));
}

@Test
Expand Down