Skip to content

[CLI-322] Add '-' as an option char and implemented extensive tests#217

Merged
garydgregory merged 5 commits into
apache:masterfrom
Claudenw:CLI-322_add_kabab-format
Feb 14, 2024
Merged

[CLI-322] Add '-' as an option char and implemented extensive tests#217
garydgregory merged 5 commits into
apache:masterfrom
Claudenw:CLI-322_add_kabab-format

Conversation

@Claudenw

@Claudenw Claudenw commented Jan 8, 2024

Copy link
Copy Markdown
Contributor

Fix for CLI-322

Adds kabab-format options and extensive option name testing.

@garydgregory

Copy link
Copy Markdown
Member

@Claudenw
I think you mean "kabab" -> "kebab". Always run mvn before you push with the latest from git master.

@Claudenw

Copy link
Copy Markdown
Contributor Author

@Claudenw I think you mean "kabab" -> "kebab". Always run mvn before you push with the latest from git master.

Indeed, I do not know how to spell. :(

I did run 'mvn' before the push and everything worked. Got "BUILD SUCCESS" result. Just tried again and same thing. I am addressing the issues from the build now.

@codecov-commenter

codecov-commenter commented Jan 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f6b23b) 91.90% compared to head (38e15c4) 91.93%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
+ Coverage     91.90%   91.93%   +0.03%     
- Complexity      575      580       +5     
============================================
  Files            22       22              
  Lines          1247     1252       +5     
  Branches        210      211       +1     
============================================
+ Hits           1146     1151       +5     
  Misses           63       63              
  Partials         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Claudenw Claudenw requested a review from garydgregory January 11, 2024 10:21
@Claudenw

Copy link
Copy Markdown
Contributor Author

The build fails on 22-ea which fails with a spotbugs execution error, It seems like spotbugs is not yet supported on 22-ea.

@garydgregory

Copy link
Copy Markdown
Member

RE 22-ea, that should be fixed by the next commons-parent release, so don't worry about that part.

@Claudenw

Copy link
Copy Markdown
Contributor Author

@garydgregory Looks like it works. Can I get a review plz.

* @param c the char to look for.
* @return {@code true} if {@code c} was in {@code ary}, {@code false} otherwise.
*/
private static boolean search(final char[] ary, final char c) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ary' is a poor parameter name here, almost any else else is better: 'chars', 'array, 'buffer'...

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Claudenw
The site needs matching updates to document this feature.

@Claudenw

Copy link
Copy Markdown
Contributor Author

@garydgregory updated as requested

@Claudenw Claudenw requested a review from garydgregory January 29, 2024 09:55
@garydgregory

Copy link
Copy Markdown
Member

Hi @Claudenw
Run mvn locally before you push to catch these build failures.

@Claudenw Claudenw force-pushed the CLI-322_add_kabab-format branch from 4c8fe4c to 38e15c4 Compare February 8, 2024 11:45
@Claudenw Claudenw changed the title Added '-' as an option char and implemented extensive tests CLI-322: Added '-' as an option char and implemented extensive tests Feb 8, 2024
@garydgregory garydgregory changed the title CLI-322: Added '-' as an option char and implemented extensive tests CLI-322: Add '-' as an option char and implemented extensive tests Feb 14, 2024
@garydgregory garydgregory merged commit 19fb139 into apache:master Feb 14, 2024
@garydgregory garydgregory changed the title CLI-322: Add '-' as an option char and implemented extensive tests [CLI-322] Add '-' as an option char and implemented extensive tests Feb 14, 2024
@Claudenw Claudenw deleted the CLI-322_add_kabab-format branch February 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants