[CLI-322] Add '-' as an option char and implemented extensive tests#217
Conversation
|
@Claudenw |
Indeed, I do not know how to spell. :( I did run 'mvn' before the push and everything worked. Got "BUILD SUCCESS" result. Just tried again and same thing. I am addressing the issues from the build now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
============================================
+ Coverage 91.90% 91.93% +0.03%
- Complexity 575 580 +5
============================================
Files 22 22
Lines 1247 1252 +5
Branches 210 211 +1
============================================
+ Hits 1146 1151 +5
Misses 63 63
Partials 38 38 ☔ View full report in Codecov by Sentry. |
|
The build fails on 22-ea which fails with a spotbugs execution error, It seems like spotbugs is not yet supported on 22-ea. |
|
RE 22-ea, that should be fixed by the next commons-parent release, so don't worry about that part. |
|
@garydgregory Looks like it works. Can I get a review plz. |
| * @param c the char to look for. | ||
| * @return {@code true} if {@code c} was in {@code ary}, {@code false} otherwise. | ||
| */ | ||
| private static boolean search(final char[] ary, final char c) { |
There was a problem hiding this comment.
'ary' is a poor parameter name here, almost any else else is better: 'chars', 'array, 'buffer'...
garydgregory
left a comment
There was a problem hiding this comment.
Hi @Claudenw
The site needs matching updates to document this feature.
|
@garydgregory updated as requested |
|
Hi @Claudenw |
4c8fe4c to
38e15c4
Compare
Fix for CLI-322
Adds kabab-format options and extensive option name testing.