Skip to content

[CLI-327] Fix for expected textual date values.#244

Merged
garydgregory merged 2 commits into
apache:masterfrom
Claudenw:CLI-327_Date_processing_fails_on_some_systems
Mar 3, 2024
Merged

[CLI-327] Fix for expected textual date values.#244
garydgregory merged 2 commits into
apache:masterfrom
Claudenw:CLI-327_Date_processing_fails_on_some_systems

Conversation

@Claudenw

@Claudenw Claudenw commented Mar 2, 2024

Copy link
Copy Markdown
Contributor

Fixes for CLI-327

In some cases the time zone for the expected date string is different than the hard coded version. This change creates the expected value from a known simple date format of the Date argument so that the expected value always matches the produced time zone.

@Claudenw Claudenw self-assigned this Mar 2, 2024
@codecov-commenter

codecov-commenter commented Mar 2, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.09%. Comparing base (9f6b23b) to head (1b9009a).
⚠️ Report is 559 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
+ Coverage     91.90%   92.09%   +0.19%     
- Complexity      575      592      +17     
============================================
  Files            22       22              
  Lines          1247     1265      +18     
  Branches        210      211       +1     
============================================
+ Hits           1146     1165      +19     
+ Misses           63       60       -3     
- Partials         38       40       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@garydgregory

Copy link
Copy Markdown
Member

Hi @Claudenw
Thank you for your PR.
The explanation in the description of this PR needs to be a comment in the test to warn people NOT to write the old style of test again.

@Claudenw

Claudenw commented Mar 3, 2024

Copy link
Copy Markdown
Contributor Author

Hi @Claudenw Thank you for your PR. The explanation in the description of this PR needs to be a comment in the test to warn people NOT to write the old style of test again.

Added comments to the 3 tests.

@garydgregory garydgregory merged commit a5acbe4 into apache:master Mar 3, 2024
asfgit pushed a commit that referenced this pull request Mar 3, 2024
@garydgregory

Copy link
Copy Markdown
Member

TY @Claudenw
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants