Skip to content

[CLI-287] Allow whitespace-only header and footer#26

Merged
garydgregory merged 2 commits into
apache:masterfrom
MrQubo:CLI-287
Oct 22, 2021
Merged

[CLI-287] Allow whitespace-only header and footer#26
garydgregory merged 2 commits into
apache:masterfrom
MrQubo:CLI-287

Conversation

@MrQubo

@MrQubo MrQubo commented Jun 10, 2018

Copy link
Copy Markdown
Contributor

@garydgregory

Copy link
Copy Markdown
Member

Seems reasonable. What do others think?

@enedil

enedil commented Feb 25, 2021

Copy link
Copy Markdown

Seems reasonable. What do others think?

I also think it seems reasonable.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 96.358% when pulling 0faa49c on MrQubo:CLI-287 into 66cc7b4 on apache:master.

@garydgregory

Copy link
Copy Markdown
Member

@MrQubo
May you please rebase on git master? I could not get one of the new tests to pass when I tried to bring the changes in manually.
TY.

@MrQubo MrQubo force-pushed the CLI-287 branch 2 times, most recently from a1e84f0 to 5cc80cc Compare October 21, 2021 17:14
@MrQubo

MrQubo commented Oct 21, 2021

Copy link
Copy Markdown
Contributor Author

@garydgregory I've fixed the tests, these new tests are more implementation-agnostic.

@garydgregory garydgregory merged commit 82403d0 into apache:master Oct 22, 2021
asfgit pushed a commit that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants