[CLI-331] Handle reporting of deprecated options when parameters are not String type.#270
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
============================================
+ Coverage 91.90% 95.67% +3.77%
- Complexity 575 653 +78
============================================
Files 22 23 +1
Lines 1247 1364 +117
Branches 210 222 +12
============================================
+ Hits 1146 1305 +159
+ Misses 63 25 -38
+ Partials 38 34 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@garydgregory various reports say the coverage went up or down. I moved the check so that it occurs more frequently (both String and Option tests) so I don't know how there can be less coverage. |
|
Hi @Claudenw |
There was a problem hiding this comment.
Hi @Claudenw
Thank you for the pull request.
The code coverage shows not all new branches in this PR are covered, which causes the build to fail.
Please add tests to cover the new branches.
Remember to run 'mvn' before you push.
You can see an HTML view of the coverage by running 'mvn clean install site' and looking at the report generated in the 'target/site' folder. |
|
`mvn clean install` dies because of the code coverage issue.
…On Sat, May 11, 2024 at 2:48 PM Gary Gregory ***@***.***> wrote:
@garydgregory <https://github.com/garydgregory> various reports say the
coverage went up or down. I moved the check so that it occurs more
frequently (both String and Option tests) so I don't know how there can be
less coverage.
You can see an HTML view of the coverage by running 'mvn clean install
site' and looking at the report generated in the 'target/site' folder.
—
Reply to this email directly, view it on GitHub
<#270 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASTVHR7MO6V3TLWBPHMVHLZBYHRHAVCNFSM6AAAAABHR3LZLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVG4ZTKNZUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
LinkedIn: http://www.linkedin.com/in/claudewarren
|
The boolean system property 'commons.jacoco.haltOnFailure' controls whether the build fails or not on this condition. |
|
TY @Claudenw |
Fixes CLI-331