Skip to content

[CLI-331] Handle reporting of deprecated options when parameters are not String type.#270

Merged
garydgregory merged 3 commits into
apache:masterfrom
Claudenw:CLI-331_Deprecated_usage_not_detected
May 11, 2024
Merged

[CLI-331] Handle reporting of deprecated options when parameters are not String type.#270
garydgregory merged 3 commits into
apache:masterfrom
Claudenw:CLI-331_Deprecated_usage_not_detected

Conversation

@Claudenw

@Claudenw Claudenw commented May 11, 2024

Copy link
Copy Markdown
Contributor

Fixes CLI-331

@codecov-commenter

codecov-commenter commented May 11, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.67%. Comparing base (9f6b23b) to head (a41fdff).
⚠️ Report is 724 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
+ Coverage     91.90%   95.67%   +3.77%     
- Complexity      575      653      +78     
============================================
  Files            22       23       +1     
  Lines          1247     1364     +117     
  Branches        210      222      +12     
============================================
+ Hits           1146     1305     +159     
+ Misses           63       25      -38     
+ Partials         38       34       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Claudenw Claudenw requested review from epugh and garydgregory May 11, 2024 11:35
@Claudenw

Copy link
Copy Markdown
Contributor Author

@garydgregory various reports say the coverage went up or down. I moved the check so that it occurs more frequently (both String and Option tests) so I don't know how there can be less coverage.

@garydgregory

Copy link
Copy Markdown
Member

Hi @Claudenw
Thank you for the pull request.
The code coverage shows not all new branches in this PR are covered, which causes the build to fail.

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Claudenw
Thank you for the pull request.
The code coverage shows not all new branches in this PR are covered, which causes the build to fail.
Please add tests to cover the new branches.
Remember to run 'mvn' before you push.

@garydgregory

Copy link
Copy Markdown
Member

@garydgregory various reports say the coverage went up or down. I moved the check so that it occurs more frequently (both String and Option tests) so I don't know how there can be less coverage.

You can see an HTML view of the coverage by running 'mvn clean install site' and looking at the report generated in the 'target/site' folder.

@Claudenw

Claudenw commented May 11, 2024 via email

Copy link
Copy Markdown
Contributor Author

@garydgregory

Copy link
Copy Markdown
Member

mvn clean install dies because of the code coverage issue.

On Sat, May 11, 2024 at 2:48 PM Gary Gregory @.> wrote: @garydgregory https://github.com/garydgregory various reports say the coverage went up or down. I moved the check so that it occurs more frequently (both String and Option tests) so I don't know how there can be less coverage. You can see an HTML view of the coverage by running 'mvn clean install site' and looking at the report generated in the 'target/site' folder. — Reply to this email directly, view it on GitHub <#270 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASTVHR7MO6V3TLWBPHMVHLZBYHRHAVCNFSM6AAAAABHR3LZLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVG4ZTKNZUGQ . You are receiving this because you were mentioned.Message ID: @.>
-- LinkedIn: http://www.linkedin.com/in/claudewarren

The boolean system property 'commons.jacoco.haltOnFailure' controls whether the build fails or not on this condition.

@garydgregory garydgregory merged commit c63265b into apache:master May 11, 2024
@garydgregory

Copy link
Copy Markdown
Member

TY @Claudenw
Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants