Fix issue with groups not being reported in help output.

[Claudenw]

AbstractHelpFormatter:

• Swapped printHelp using Iterable with printHelp using Options. Effectively switching to using Options class to print the help.

• Removed public String toSyntaxOptions(final Iterable options) as it was added in this version and should have only been used internally.

HelpFormatterTest:

• removed toSyntaxOptions using Iterable test.

• added a printHelpTest with Iterable as previously we depended on printHelpTest with Option to test the code branch.

• added verifyOptionGroupingOutput as a test to show that reported issue is corrected.

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

• Read the contribution guidelines for this project.
• Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
• I used AI to create any part of, or all of, this pull request.
• Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
• Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

[Claudenw]

@garydgregory I removed a method that was added in 1.10.0 This caused the build to fail. I can put it back if that is what we need to do. But we should mark it as as do not use.

In addition, there is no jira ticket for this as none was created to go with the reported issue. I can create one if you wish. I did not as I was not sure how you wanted to handle this and because I am pressed for time and I wanted to at least get the fix in front of your eyes ASAP.

[garydgregory]

Hi @Claudenw

Thank you for the PR :)

You CANNOT break binary compatibility within a major release line.

I've added back toSyntaxOptions() in this PR. Let's see about the other breakage...

[Claudenw]

@garydgregory just for my clarification, when does the inclusion of a new method become part of the binary compatibility?

If a method was added in 1.10.0-SNAPSHOT can it not be removed before 1.10.0 is released? The method in question was added in 1.10.0-SNAPSHOT and I thought this was 1.10.0 that we are working on. Hence my confusion.

Please clarify for my edification.

[garydgregory]

Hi @Claudenw

We are both right 😉

If a method was added in 1.10.0-SNAPSHOT can it not be removed before 1.10.0 is released? The method in question was added in 1.10.0-SNAPSHOT and I thought this was 1.10.0 that we are working on.

Yes, but version 1.10.0 was released in September this year. We are now on 1.11.0-SNAPSHOT.

[Claudenw]

2 comments.

DOH!

and I think this should be versioned as 1.10.1 unless there are other changes.

[garydgregory]

Hello @Claudenw
The next version will be 1.11.0, see changes.xml.

[garydgregory]

Thank you @Claudenw , merged!