Skip to content

Skipping empty tests#5

Closed
august782 wants to merge 2 commits into
apache:trunkfrom
august782:ignoretests
Closed

Skipping empty tests#5
august782 wants to merge 2 commits into
apache:trunkfrom
august782:ignoretests

Conversation

@august782

Copy link
Copy Markdown

This pull request adds @ignore to tests with purposely left empty test bodies due to the features not being implemented (the @test is added as well due to how JUnit processes annotations and would not actually skip these tests unless they are annotated with @test). With these ignores, 54 test cases can be skipped from execution.

@britter

britter commented Jun 20, 2016

Copy link
Copy Markdown
Member

Hello @august782, very nice. How about moving the reason for skipping the tests from the test method body to the @Ignore annotation?

Example:

    @Override @Test @Ignore("not supported by the BasicParser")
      public void testDoubleDash2() throws Exception
      {
      }

@august782

Copy link
Copy Markdown
Author

Thank you for the suggestion. This new pull request moves that comment in each test body into the @ignore annotation for each test.

@britter

britter commented Jun 20, 2016

Copy link
Copy Markdown
Member

Fixed in SVN in rev 1749393. Should sync to GitHub shortly. Thank you!

@asfgit asfgit closed this in f6af623 Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants