Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
updated unit tests
  • Loading branch information
waso committed Oct 22, 2021
commit c06fb279acf9c191508b9ada69dd1a847e33119a
2 changes: 1 addition & 1 deletion src/changes/changes.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<action type="add" dev="ggregory" due-to="Alex Nordlund" issue="CLI-282">
TypeHandler should throw ParseException for an unsupported class.
</action>
<action type="add" dev="ggregory" due-to="waso, Gary Gregory">
<action type="add" dev="ggregory" due-to="Waldemar Sojka, Gary Gregory">
Added setter for Builder.option #33.
</action>
<!-- UPDATE -->
Expand Down
20 changes: 20 additions & 0 deletions src/test/java/org/apache/commons/cli/OptionTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,26 @@ public void testBuilderInsufficientParams2() {
Option.builder(null).desc("desc").build();
}

@Test(expected = IllegalArgumentException.class)
public void testBuilderInvalidOptionName1() {
Option.builder().option("invalid?");
}

@Test(expected = IllegalArgumentException.class)
public void testBuilderInvalidOptionName2() {
Option.builder().option("invalid@");
}

@Test(expected = IllegalArgumentException.class)
public void testBuilderInvalidOptionName3() {
Option.builder("invalid?");
}

@Test(expected = IllegalArgumentException.class)
public void testBuilderInvalidOptionName4() {
Option.builder("invalid@");
}

@Test
public void testBuilderMethods() {
final char defaultSeparator = (char) 0;
Expand Down