Skip to content

Commit 02011f8

Browse files
committed
[CODEC-246] ColognePhoneticTest.testIsEncodeEquals missing assertions.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1832543 13f79535-47bb-0310-9956-ffa450edef68
1 parent 67e7655 commit 02011f8

1 file changed

Lines changed: 1 addition & 16 deletions

File tree

src/test/java/org/apache/commons/codec/language/ColognePhoneticTest.java

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ public void testHyphen() throws EncoderException {
136136
public void testIsEncodeEquals() {
137137
//@formatter:off
138138
final String[][] data = {
139+
{"Muller", "M\u00fcller"}, // Müller
139140
{"Meyer", "Mayr"},
140141
{"house", "house"},
141142
{"House", "house"},
@@ -150,22 +151,6 @@ public void testIsEncodeEquals() {
150151
}
151152
}
152153

153-
@Test
154-
@Ignore("https://issues.apache.org/jira/browse/CODEC-246")
155-
public void testIsEncodeEqualsCodec246() {
156-
//@formatter:off
157-
final String[][] data = {
158-
{"Meyer", "M\u00fcller"}, // Müller
159-
};
160-
//@formatter:on
161-
for (final String[] element : data) {
162-
// This just compares and only shows we do not blow up
163-
final boolean encodeEqual = this.getStringEncoder().isEncodeEqual(element[1], element[0]);
164-
// Fails for https://issues.apache.org/jira/browse/CODEC-246
165-
Assert.assertTrue(element[1] + " != " + element[0], encodeEqual);
166-
}
167-
}
168-
169154
@Test
170155
public void testVariationsMella() throws EncoderException {
171156
final String data[] = {"mella", "milah", "moulla", "mellah", "muehle", "mule"};

0 commit comments

Comments
 (0)