CODEC-285 Better StringEncoderAbstractTest testEncodeNull (#41)

* CODEC-284 update to hamcrest v2.2

* CODEC-285 update to junit v5.6.0

* CODEC-285 update to junit v5.8.2 via junit-bom

* StringEncoderAbstractTest.testEncodeNull no test actually throw EncoderException

Author: nhojpatrick

pom.xml

@@ -274,6 +274,9 @@ limitations under the License.
   <properties>
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
+    <!-- Fix to build on JDK 7: version 4.0.0 requires Java 8. -->
+    <!-- Can be dropped when CP 49 is released -->
+    <commons.felix.version>3.5.1</commons.felix.version>
     <commons.componentid>codec</commons.componentid>
     <commons.module.name>org.apache.commons.codec</commons.module.name>
     <commons.jira.id>CODEC</commons.jira.id>

src/test/java/org/apache/commons/codec/StringEncoderAbstractTest.java

@@ -21,6 +21,12 @@
 
 import org.junit.Assert;
 import org.junit.Test;
+import org.junit.jupiter.api.function.Executable;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.core.Is.is;
+import static org.hamcrest.core.IsEqual.equalTo;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 /**
  */
@@ -59,13 +65,9 @@ public void testEncodeEmpty() throws Exception {
     }
 
     @Test
-    public void testEncodeNull() throws Exception {
+    public void testEncodeNull() throws EncoderException {
         final StringEncoder encoder = this.getStringEncoder();
-        try {
-            encoder.encode(null);
-        } catch (final EncoderException ee) {
-            // An exception should be thrown
-        }
+        encoder.encode(null);
     }
 
     @Test