CODEC-285 Better StringEncoderAbstractTest testEncodeNull#41
Merged
garydgregory merged 4 commits intoFeb 17, 2022
Merged
Conversation
4d09f50 to
19c6d71
Compare
Contributor
Author
|
If easier I can collapse these into the CODEC-285 PR |
19c6d71 to
b5f0b0f
Compare
b5f0b0f to
034ccdf
Compare
034ccdf to
a5fcecf
Compare
omosteven
pushed a commit
to omosteven/commons-codec-lab-work
that referenced
this pull request
Jan 8, 2025
* CODEC-284 update to hamcrest v2.2 * CODEC-285 update to junit v5.6.0 * CODEC-285 update to junit v5.8.2 via junit-bom * StringEncoderAbstractTest.testEncodeNull no test actually throw EncoderException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for PR #39
From experience people write tests that don't check exceptions correctly, either they are not thrown, or a different than expected line throws that exception, or it's the wrong exception, or wrong message.
This test doesn't ever throw the exception listed, so why is it catching and ignoring if thrown???