CODEC-221 HmacUtils.updateHmac calls reset() unnecessarily

sebbASF · sebbASF · commit 8bac2b6a1bd1 · 2016-05-19T15:31:10.000Z
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/codec/trunk@1744597 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -42,8 +42,10 @@ The <action> type attribute can be add,update,fix,remove.
     <author>Apache Commons Developers</author>
   </properties>
   <body>
-    <release version="1.11" date="DD MM 2015" description="Feature and fix release.">        
-      <action dev="sebb" type="fix" issue="CODEC-200" due-to="Luciano Vernaschi">Base32.HEX_DECODE_TABLE contains the wrong value 32</action>   
+    <release version="1.11" date="DD MM 2015" description="Feature and fix release.">
+      <!-- The first attribute below should be the issue id; makes it easier to navigate in the IDE outline -->        
+      <action issue="CODEC-221" dev="sebb" type="update">HmacUtils.updateHmac calls reset() unnecessarily</action>   
+      <action issue="CODEC-200" dev="sebb" type="fix" due-to="Luciano Vernaschi">Base32.HEX_DECODE_TABLE contains the wrong value 32</action>   
       <action dev="ggregory" type="fix" issue="CODEC-207" due-to="Gary Gregory">Charsets Javadoc breaks build when using Java 8</action>         
       <action dev="ggregory" type="fix" issue="CODEC-199" due-to="Yossi Tamari">Bug in HW rule in Soundex</action>         
       <action dev="ggregory" type="fix" issue="CODEC-209" due-to="Gary Gregory">Javadoc for SHA-224 DigestUtils methods should mention Java 1.8.0 restriction instead of 1.4.0.</action>         
diff --git a/src/main/java/org/apache/commons/codec/digest/HmacUtils.java b/src/main/java/org/apache/commons/codec/digest/HmacUtils.java
@@ -792,7 +792,7 @@ public static String hmacSha512Hex(final String key, final String valueToDigest)
     // update
 
     /**
-     * Updates the given {@link Mac} with the value.
+     * Resets and then updates the given {@link Mac} with the value.
      *
      * @param mac
      *            the initialized {@link Mac} to update
@@ -809,7 +809,7 @@ public static Mac updateHmac(final Mac mac, final byte[] valueToDigest) {
     }
 
     /**
-     * Updates the given {@link Mac} with the value.
+     * Resets and then updates the given {@link Mac} with the value.
      *
      * @param mac
      *            the initialized {@link Mac} to update
@@ -838,7 +838,7 @@ public static Mac updateHmac(final Mac mac, final InputStream valueToDigest) thr
     }
 
     /**
-     * Updates the given {@link Mac} with the value.
+     * Resets and then updates the given {@link Mac} with the value.
      *
      * @param mac
      *            the initialized {@link Mac} to update

Original file line number	Diff line number	Diff line change
`@@ -792,7 +792,7 @@ public static String hmacSha512Hex(final String key, final String valueToDigest)`
`792`	`792`	`// update`
`793`	`793`
`794`	`794`	`/**`
`795`		`- * Updates the given {@link Mac} with the value.`
	`795`	`+ * Resets and then updates the given {@link Mac} with the value.`
`796`	`796`	`*`
`797`	`797`	`* @param mac`
`798`	`798`	`* the initialized {@link Mac} to update`
`@@ -809,7 +809,7 @@ public static Mac updateHmac(final Mac mac, final byte[] valueToDigest) {`
`809`	`809`	`}`
`810`	`810`
`811`	`811`	`/**`
`812`		`- * Updates the given {@link Mac} with the value.`
	`812`	`+ * Resets and then updates the given {@link Mac} with the value.`
`813`	`813`	`*`
`814`	`814`	`* @param mac`
`815`	`815`	`* the initialized {@link Mac} to update`
`@@ -838,7 +838,7 @@ public static Mac updateHmac(final Mac mac, final InputStream valueToDigest) thr`
`838`	`838`	`}`
`839`	`839`
`840`	`840`	`/**`
`841`		`- * Updates the given {@link Mac} with the value.`
	`841`	`+ * Resets and then updates the given {@link Mac} with the value.`
`842`	`842`	`*`
`843`	`843`	`* @param mac`
`844`	`844`	`* the initialized {@link Mac} to update`