More tests#1
Closed
lathspell wants to merge 14 commits into
Closed
Conversation
added 14 commits
September 1, 2012 01:39
Note that the "// NOOP" comment was misleading, the salt variable actually was modified inside the for loop. This functionality will never be used though as the salt is checked some lines above to an exact length of 2. Filling it with "A" would be a very bad idea anyway as e.g. glibc fills a one-char salt with exactly the same char so our implementation would have been incompatible!
Member
|
@lathspell can you please rebase this against head and only include the new tests? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please apply the following commits:
$ git log --name-status aead18a..71bdb57
commit 71bdb57
Author: Christian Hammers ch@lathspell.de
Date: Sat Sep 1 01:46:08 2012 +0200
M pom.xml
commit 248bad1
Author: Christian Hammers ch@lathspell.de
Date: Sat Sep 1 01:45:06 2012 +0200
M src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java
commit 3b7f1a5
Author: Christian Hammers ch@lathspell.de
Date: Sat Sep 1 01:43:00 2012 +0200
M src/test/java/org/apache/commons/codec/digest/B64Test.java
commit 763d05d
Author: Christian Hammers ch@lathspell.de
Date: Sat Sep 1 01:42:52 2012 +0200
M src/test/java/org/apache/commons/codec/digest/Apr1CryptTest.java
commit f159452
Author: Christian Hammers ch@lathspell.de
Date: Sat Sep 1 01:41:28 2012 +0200
M src/test/java/org/apache/commons/codec/digest/UnixCryptTest.java
commit 704e046
Author: Christian Hammers ch@lathspell.de
Date: Sat Sep 1 01:39:49 2012 +0200
M src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
M src/test/java/org/apache/commons/codec/digest/CryptTest.java