Skip to content

Avoid calculations the minimum or the maximum of two numbers manually… #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebbASF merged 1 commit into from
Apr 16, 2022
Merged

Avoid calculations the minimum or the maximum of two numbers manually… #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,7 @@ private static int createPositiveCapacity(final int minCapacity) {
// Integer.MAX_VALUE length array.
// The result is that we may have to allocate an array of this size more than once if
// the capacity must be expanded again.
return (minCapacity > MAX_BUFFER_SIZE) ?
minCapacity :
MAX_BUFFER_SIZE;
return Math.max(minCapacity, MAX_BUFFER_SIZE);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/codec/digest/Md5Crypt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ public static String md5Crypt(final byte[] keyBytes, final String salt, final St
byte[] finalb = ctx1.digest();
int ii = keyLen;
while (ii > 0) {
ctx.update(finalb, 0, ii > 16 ? 16 : ii);
ctx.update(finalb, 0, Math.min(ii, 16));
ii -= 16;
}

Expand Down