Skip to content

(chore) Fix minor typos#139

Merged
kinow merged 1 commit into
apache:masterfrom
marcwrobel:fix-typos
Jul 15, 2022
Merged

(chore) Fix minor typos#139
kinow merged 1 commit into
apache:masterfrom
marcwrobel:fix-typos

Conversation

@marcwrobel

Copy link
Copy Markdown
Contributor

Fix various minor typos in :

  • project documentations,
  • javadoc and comments,
  • method attribute names,
  • test method names.

Fix various minor typos in :

- project documentations,
- javadoc and comments,
- method attribute names,
- test method names.
@codecov-commenter

codecov-commenter commented Jul 15, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (11f9498) to head (2ca75a4).
⚠️ Report is 1163 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #139   +/-   ##
=========================================
  Coverage     92.17%   92.17%           
  Complexity     1745     1745           
=========================================
  Files            67       67           
  Lines          4652     4652           
  Branches        746      746           
=========================================
  Hits           4288     4288           
  Misses          249      249           
  Partials        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kinow kinow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Some are grammar or writing style changes (e.g. case-sensitive vs. case sensitive), but no objections from me 👍

Thank you @marcwrobel !

/**
* Place holder for the bytes we're dealing with for our based logic.
* Bitwise operations store and extract the encoding or decoding from this variable.
*/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: check out in git history if there was a variable below this comment before, or if this comment was intended for a block of variables?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment was for bitWorkAread6f305d

That field was removed in CODEC-96, so safe to remove this comment now 🕵️ — 3f41cf1

kinow added a commit that referenced this pull request Jul 15, 2022
@kinow kinow merged commit 2ca75a4 into apache:master Jul 15, 2022
@kinow

kinow commented Jul 15, 2022

Copy link
Copy Markdown
Member

Merged, thanks @marcwrobel !

@marcwrobel marcwrobel deleted the fix-typos branch July 16, 2022 08:45
omosteven pushed a commit to omosteven/commons-codec-lab-work that referenced this pull request Jan 8, 2025
omosteven pushed a commit to omosteven/commons-codec-lab-work that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants