Skip to content

CODEC-311: Fix possible ArrayIndexOutOfBoundException thrown by RefinedSoundex.getMappingCode() #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 3 commits into from
Nov 25, 2023
+15 −1
Merged

CODEC-311: Fix possible ArrayIndexOutOfBoundException thrown by RefinedSoundex.getMappingCode() #219

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c374ada
CODEC-311: Fix possible ArrayIndexOutOfBoundException
arthurscchan Nov 21, 2023
f33a657
CODEC-311: Add unit test
arthurscchan Nov 22, 2023
a9c487e
Use final
garydgregory Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CODEC-311: Add unit test 
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
  • Loading branch information
@arthurscchan
arthurscchan committed Nov 24, 2023
commit f33a657e27a976096b1fff3db80b38146b57bc42
10 changes: 10 additions & 0 deletions src/test/java/org/apache/commons/codec/language/RefinedSoundexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,16 @@ public void testGetMappingCodeNonLetter() {
assertEquals(0, code, "Code does not equals zero");
}

@Test
public void testInvalidSoundexCharacter() {
final char[] invalid = new char[256];
for (int i = 0; i < invalid.length; i++) {
invalid[i] = (char)i;
}

assertEquals(new RefinedSoundex().encode(new String(invalid)), "A0136024043780159360205050136024043780159360205053");
}

@Test
public void testNewInstance() {
assertEquals("D6043", new RefinedSoundex().soundex("dogs"));
Expand Down