Skip to content

CODEC-313: Fix possible ArrayIndexOutOfBoundsException thrown by QuotedPrintableCodec.encodeQuotedPrintable() method #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 2 commits into from
Nov 25, 2023
Merged

CODEC-313: Fix possible ArrayIndexOutOfBoundsException thrown by QuotedPrintableCodec.encodeQuotedPrintable() method #221

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2b68eb
CODEC-313: Fix possible ArrayIndexOutOfBoundsException
arthurscchan Nov 21, 2023
130dafc
CODEC-313: Add unit test
arthurscchan Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CODEC-313: Add unit test 
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
  • Loading branch information
@arthurscchan
arthurscchan committed Nov 24, 2023
commit 130dafc4e981ce2caaa7f65b6e5eee9020a87786
6 changes: 6 additions & 0 deletions src/test/java/org/apache/commons/codec/net/QuotedPrintableCodecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,12 @@ public void testSoftLineBreakEncode() throws Exception {
assertEquals(qpdata, qpcodec.encode(decoded));
}

@Test
public void testTooShortByteArray() throws Exception{
final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
assertNull(qpcodec.encode("AA"), "Result should be null.");
}

@Test
public void testTrailingSpecial() throws Exception {
final QuotedPrintableCodec qpcodec = new QuotedPrintableCodec(true);
Expand Down