CODEC-259: fixed ByteBuffer issues and updated tests#23
Closed
Megaprog wants to merge 1 commit into
Closed
Conversation
1 similar comment
garydgregory
requested changes
Jul 15, 2019
|
|
||
| @Test | ||
| public void testDecodeByteBufferEmpty() throws DecoderException { | ||
| assertTrue(Arrays.equals(new byte[0], new Hex().decode(ByteBuffer.allocate(0)))); |
Member
There was a problem hiding this comment.
I would prefer to add tests instead of updating each call to allocate with a call to allocateDirect. This is something that could be done either with subclasses (one for allocate, one for allocateDirect) or with parameterizing the test with lambdas.
Author
There was a problem hiding this comment.
I'm sorry but have no time for that
garydgregory
left a comment
Member
There was a problem hiding this comment.
Please debase on master, the main and test code are different now.
omosteven
pushed a commit
to omosteven/commons-codec-lab-work
that referenced
this pull request
Jan 8, 2025
org.apache.commons.codec.binary.Hex. Closes apache#23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#CODEC-259