Skip to content

Base64 should be open for different alphabets #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cljk wants to merge 7 commits into from
Closed

Base64 should be open for different alphabets #24

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c44f596
open for different alphabets
cljk Jul 23, 2019
50aa370
open for different alphabets - add javadoc
cljk Jul 23, 2019
669e6f4
open for different alphabets - add test
cljk Jul 23, 2019
31ece68
open for different alphabets - add unfixed failing test for decoder
cljk Jul 23, 2019
4ed1cf9
open for different alphabets - add calculating of decode table for cu…
cljk Jul 23, 2019
8b29c52
open for different alphabets - encode tables private again
cljk Jul 23, 2019
3e0d13c
open for different alphabets - check for encodeTable length
cljk Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
open for different alphabets
  • Loading branch information
@cljk
cljk committed Jul 23, 2019
commit c44f596cdd942ec73011581b708d752c54fa1ec8
10 changes: 9 additions & 1 deletion src/main/java/org/apache/commons/codec/binary/Base64.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,14 @@ public Base64(final int lineLength, final byte[] lineSeparator) {
* @since 1.4
*/
public Base64(final int lineLength, final byte[] lineSeparator, final boolean urlSafe) {
this(lineLength, lineSeparator, urlSafe ? URL_SAFE_ENCODE_TABLE : STANDARD_ENCODE_TABLE);
}

public Base64(byte[] encodeTable) {
this(0, CHUNK_SEPARATOR, encodeTable);
}

public Base64(final int lineLength, final byte[] lineSeparator, byte[] encodingTable) {
super(BYTES_PER_UNENCODED_BLOCK, BYTES_PER_ENCODED_BLOCK,
lineLength,
lineSeparator == null ? 0 : lineSeparator.length);
Expand All @@ -294,7 +302,7 @@ public Base64(final int lineLength, final byte[] lineSeparator, final boolean ur
this.lineSeparator = null;
}
this.decodeSize = this.encodeSize - 1;
this.encodeTable = urlSafe ? URL_SAFE_ENCODE_TABLE : STANDARD_ENCODE_TABLE;
this.encodeTable = encodingTable;
}

/**
Expand Down