[CODEC-263] test for user reported issue#240
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
============================================
+ Coverage 92.05% 92.27% +0.22%
- Complexity 1746 1756 +10
============================================
Files 67 67
Lines 4609 4624 +15
Branches 712 714 +2
============================================
+ Hits 4243 4267 +24
+ Misses 253 248 -5
+ Partials 113 109 -4 ☔ View full report in Codecov by Sentry. |
garydgregory
reviewed
Feb 5, 2024
| } | ||
|
|
||
| public void testCodec263(){ | ||
| Base64.decodeBase64("publishMessage"); |
Member
There was a problem hiding this comment.
@elharo
It would make it more obvious IMO to refactor the magic strings into a local variable (or a constant).
omosteven
pushed a commit
to omosteven/commons-codec-lab-work
that referenced
this pull request
Jan 8, 2025
* test for user reported issue * test isBase64 * Add Javadoc * Fix whitespace --------- Co-authored-by: Gary Gregory <garydgregory@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Near as I can tell this issue doesn't reproduce and can be closed. @garydgregory