CODEC-285 Base32InputStreamTest testReadOutOfBounds

[nhojpatrick]

Follow up for PR #39

From experience people write tests that don't check exceptions correctly, either they are not thrown, or a different than expected line throws that exception, or it's the wrong exception, or wrong message.

Using assertAll and assertThrows to explicitly check the expected line throws the expected exception, and all done in parallel not sequentially.

[coveralls]

Coverage remained the same at 93.976% when pulling dc77c32 on nhojpatrick:CODEC-285_Base32InputStreamTest_testReadOutOfBounds into e87ac43 on apache:master.

[garydgregory]

Please, let's not add assertions on the contents of exception messages, that's a maintenance headache.

[nhojpatrick]

Not checking exception message it like just checking a method returns a non null value.
Anyone changing a method would expect to have to fix any tests they break, so why not any tests asserting the message?
I've done this multiple times as discovered tests are not checking what your expecting, they are failing with the correct throwable type but not for the correct reason.

It's not like I'm checking the stackstrace and asserting the correct line that the test is expecting is throwing the exception.

[garydgregory]

Closing: Superseded in git master (commit 5a03f5a)