[CODEC-295] Minor improvements#67
Merged
Merged
Conversation
Member
Author
|
HI @garydgregory @sebbASF any idea of why the Java CI it's failing? |
Member
|
@arturobernalg |
garydgregory
requested changes
Dec 11, 2020
| final int l = data.length; | ||
| final char[] out = new char[l << 1]; | ||
| encodeHex(data, 0, data.length, toDigits, out, 0); | ||
| encodeHex(data, 0, l, toDigits, out, 0); |
Member
There was a problem hiding this comment.
No mystery names please, especially "l" which can look just like a "1" depending on your font!
| inputs = null; | ||
| } else { | ||
| inputs = new String[args.length -1]; | ||
| inputs = new String[argsLength -1]; |
| if (startsWith && endsWith) { | ||
| // exact match | ||
| if (content.length() == 0) { | ||
| if (contentLength == 0) { |
Member
There was a problem hiding this comment.
Just use String#isEmpty() for 0-length checks on Strings.
| } | ||
| }; | ||
| } else if ((startsWith || endsWith) && content.length() == 0) { | ||
| } else if ((startsWith || endsWith) && contentLength == 0) { |
| * | ||
| * @throws IllegalArgumentException for some failure scenarios. | ||
| */ | ||
| @Test(expected = IllegalArgumentException.class) |
| * | ||
| * @since 1.17 | ||
| */ | ||
| public class DigestTest{ |
Member
|
@arturobernalg |
asfgit
pushed a commit
that referenced
this pull request
Dec 13, 2020
omosteven
pushed a commit
to omosteven/commons-codec-lab-work
that referenced
this pull request
Jan 8, 2025
omosteven
pushed a commit
to omosteven/commons-codec-lab-work
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CODEC-295
Minor improvement