[COLLECTIONS-600] Null-safe implementation of CollectionUtils#isEqualCollection#22
Closed
jonasholtkamp wants to merge 2 commits intoapache:trunkfrom
Closed
[COLLECTIONS-600] Null-safe implementation of CollectionUtils#isEqualCollection#22jonasholtkamp wants to merge 2 commits intoapache:trunkfrom
jonasholtkamp wants to merge 2 commits intoapache:trunkfrom
Conversation
kinow
reviewed
May 27, 2017
| public static <E> boolean isEqualCollection(final Collection<? extends E> a, | ||
| final Collection<? extends E> b, | ||
| final Equator<? super E> equator) { | ||
| if(a == null && b == null) { |
Member
There was a problem hiding this comment.
Maybe instead of repeating the checks here, we could remove the .size() checks, leaving it to be checked by the following call to the overloaded isEqualCollection.
Member
|
Ready to be merged IMO. Just waiting for feedback on this e-mail thread http://commons.markmail.org/thread/dwgs5j3bp3vryb24 Feel free to reply there if you would like to cast your opinion, or on COLLECTIONS-604 Cheers |
Member
|
@jonasholtkamp - Do you mind rebasing to master and re-opening this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other Commons
*Utilsclasses asStringUtilsetc. feature null-safe methods. With this Pull Request nowCollectionUtils#isEqualCollectiondoes, too.Fixes issue COLLECTIONS-600.