Skip to content

feat(MapUtils): Add empty string judgment #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kingsmao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(MapUtils): Add empty string judgment #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/collections4/MapUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ public static <K> short getShortValue(final Map<? super K, ?> map, final K key,
public static <K> String getString(final Map<? super K, ?> map, final K key) {
if (map != null) {
final Object answer = map.get(key);
if (answer != null) {
if (answer != null && answer != "") {
return answer.toString();
}
}
Expand Down
16 changes: 16 additions & 0 deletions src/test/java/org/apache/commons/collections4/MapUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import org.apache.commons.collections4.map.LazyMap;
import org.apache.commons.collections4.map.MultiValueMap;
import org.apache.commons.collections4.map.PredicatedMap;
import org.apache.commons.lang3.StringUtils;
import org.junit.jupiter.api.Test;

/**
Expand Down Expand Up @@ -1314,4 +1315,19 @@ private char getDecimalSeparator() {
}
return '.';
}

@Test
public void testBlankCharSequenceMap(){
final Map<String, String> blankMap = new HashMap<>();
blankMap.put("key1",null);
blankMap.put("key2","");
blankMap.put("key3","LGD");
String value1 = MapUtils.getString(blankMap, "key1");
String value2 = MapUtils.getString(blankMap, "key2");
String value3 = MapUtils.getString(blankMap, "key3");
assertTrue(StringUtils.isBlank(value1));
assertTrue(StringUtils.isBlank(value2));
assertTrue(StringUtils.isNotBlank(value3));

}
}